No dev is credited in the readme for SMS core

User avatar
SegaSnatcher
Posts: 154
Joined: Sun May 24, 2020 9:18 pm
Has thanked: 34 times
Been thanked: 40 times

No dev is credited in the readme for SMS core

Unread post by SegaSnatcher »

I believe the SMS core on MiSTer started out as a port of MiST core which was a port of Ben's Sega Master System implementation for the Papilio.

https://github.com/ben0109/Papilio-Master-System

Unless the current SMS core on MiSTer was fully rebuilt by a new dev, I think its only right to give Ben credit in the readme.

There is a link to the MiST binary in the MiSTer SMS readme, but I think it would still be more appropriate to properly credit the dev in the readme, so people don't have to click links or search around.

Something like "SMS core ported from MiST, originally developed by Ben0109." seems accurate to have in the readme. Just my opinion.
Asteld
Posts: 30
Joined: Wed Dec 01, 2021 9:56 am
Has thanked: 11 times
Been thanked: 10 times

Re: No dev is credited in the readme for SMS core

Unread post by Asteld »

FYI you (or anyone) can change the README.md yourself and make a pull request on github. Ultimately, Mister is a community project, so that would certainly be in the spirit of the project. I'm sure sorgelig would be happy to accept this.
User avatar
SegaSnatcher
Posts: 154
Joined: Sun May 24, 2020 9:18 pm
Has thanked: 34 times
Been thanked: 40 times

Re: No dev is credited in the readme for SMS core

Unread post by SegaSnatcher »

Thanks for the reply, yeah wark91 was nice enough to make a PR with that new information after we confirmed the source of SMS core.

https://github.com/MiSTer-devel/SMS_MiS ... 017c263a95
User avatar
aberu
Core Developer
Posts: 861
Joined: Tue Jun 09, 2020 8:34 pm
Location: Longmont, CO
Has thanked: 182 times
Been thanked: 258 times
Contact:

Re: No dev is credited in the readme for SMS core

Unread post by aberu »

Thanks wark!
birdybro~
Post Reply