The one thing that needs to be fixed is the ability to use custom aspect ratios for 5x crop, currently they do not work.bootsector wrote: ↑Sat Jan 30, 2021 7:18 pm @Grabulosaure do you have plans to open a pull request for these soon? Thank you so much for implementing this!
A case for 5x vertical crop in 1080p mode.
- SegaSnatcher
- Posts: 163
- Joined: Sun May 24, 2020 9:18 pm
- Has thanked: 36 times
- Been thanked: 43 times
Re: A case for 5x vertical crop in 1080p mode.
- bootsector
- Posts: 162
- Joined: Sun May 24, 2020 6:58 pm
- Has thanked: 4 times
- Been thanked: 30 times
Re: A case for 5x vertical crop in 1080p mode.
Yeah, I've noticed that. But I think it deserves a pull request as it is, so people can jump in and collaborate more easily if it's on github!SegaSnatcher wrote: ↑Mon Feb 01, 2021 9:26 amThe one thing that needs to be fixed is the ability to use custom aspect ratios for 5x crop, currently they do not work.bootsector wrote: ↑Sat Jan 30, 2021 7:18 pm @Grabulosaure do you have plans to open a pull request for these soon? Thank you so much for implementing this!
- SegaSnatcher
- Posts: 163
- Joined: Sun May 24, 2020 9:18 pm
- Has thanked: 36 times
- Been thanked: 43 times
Re: A case for 5x vertical crop in 1080p mode.
Oh, also there is a bug when you switch between 16:9 and 4:3 modes where it will get stuck to 16:9 if you change the aspect ratio in the core menu, that at least should get fixed before a PR.bootsector wrote: ↑Mon Feb 01, 2021 9:51 amYeah, I've noticed that. But I think it deserves a pull request as it is, so people can jump in and collaborate more easily if it's on github!SegaSnatcher wrote: ↑Mon Feb 01, 2021 9:26 amThe one thing that needs to be fixed is the ability to use custom aspect ratios for 5x crop, currently they do not work.bootsector wrote: ↑Sat Jan 30, 2021 7:18 pm @Grabulosaure do you have plans to open a pull request for these soon? Thank you so much for implementing this!
- bootsector
- Posts: 162
- Joined: Sun May 24, 2020 6:58 pm
- Has thanked: 4 times
- Been thanked: 30 times
Re: A case for 5x vertical crop in 1080p mode.
Hopefully Grab is still cooking this up until we'll finally see a pull request!SegaSnatcher wrote: ↑Mon Feb 01, 2021 9:56 amOh, also there is a bug when you switch between 16:9 and 4:3 modes where it will get stuck to 16:9 if you change the aspect ratio in the core menu, that at least should get fixed before a PR.bootsector wrote: ↑Mon Feb 01, 2021 9:51 amYeah, I've noticed that. But I think it deserves a pull request as it is, so people can jump in and collaborate more easily if it's on github!SegaSnatcher wrote: ↑Mon Feb 01, 2021 9:26 am
The one thing that needs to be fixed is the ability to use custom aspect ratios for 5x crop, currently they do not work.
- LamerDeluxe
- Top Contributor
- Posts: 1181
- Joined: Sun May 24, 2020 10:25 pm
- Has thanked: 828 times
- Been thanked: 266 times
Re: A case for 5x vertical crop in 1080p mode.
I notice a lot of people use the custom aspect ratio to get clean square pixels. An option for integer scaling both horizontally and vertically would handle that much more easily. Also it still doesn't seem possible to achieve horizontal only integer scaling using a custom aspect ratio.
Re: A case for 5x vertical crop in 1080p mode.
I haven’t tried this, but I think you could get horizontal only integer scaling by setting a ratio of (integer upscale):(vertical resolution set by video mode), because the default scaler behaviour is to fill the screen vertically. For example, if you’re running a 256x240 core on 1080p, you could set 1280:1080 for a five times horizontal integer upscale (and a pixel aspect ratio of 5:4.5).
I would welcome more easily controlled integer upscaling. I’d like to see menu options for “Vertical upscale (1,2,3,4,5 etc)” and “Horizontal upscale (1,2,3,4,5 etc)”, maybe with the upper limit determined by the resolution of the video mode currently set. Separate horizontal and vertical settings because a lot of the time you don’t actually want square pixels - the point of integer scaling at least for me is to get consistent pixels, which I may sometimes want to be rectangular. Wouldn’t work well for cores with changing resolutions though, unless there were separate settings for different resolutions. An alternative might be “Integer scaling (high/low)”, which would give the closest integer scaling to the set aspect ratio, with the multiple rounded up or down according to the setting.
I would welcome more easily controlled integer upscaling. I’d like to see menu options for “Vertical upscale (1,2,3,4,5 etc)” and “Horizontal upscale (1,2,3,4,5 etc)”, maybe with the upper limit determined by the resolution of the video mode currently set. Separate horizontal and vertical settings because a lot of the time you don’t actually want square pixels - the point of integer scaling at least for me is to get consistent pixels, which I may sometimes want to be rectangular. Wouldn’t work well for cores with changing resolutions though, unless there were separate settings for different resolutions. An alternative might be “Integer scaling (high/low)”, which would give the closest integer scaling to the set aspect ratio, with the multiple rounded up or down according to the setting.
- SegaSnatcher
- Posts: 163
- Joined: Sun May 24, 2020 9:18 pm
- Has thanked: 36 times
- Been thanked: 43 times
Re: A case for 5x vertical crop in 1080p mode.
Genesis core at least will do that if you use the "Corrected" aspect ratio mode in the Menu, so no need for custom aspect ratio there.LamerDeluxe wrote: ↑Tue Feb 02, 2021 11:14 am I notice a lot of people use the custom aspect ratio to get clean square pixels. An option for integer scaling both horizontally and vertically would handle that much more easily. Also it still doesn't seem possible to achieve horizontal only integer scaling using a custom aspect ratio.
-
- Posts: 7
- Joined: Mon Jan 25, 2021 6:01 am
- Has thanked: 2 times
- Been thanked: 2 times
Re: A case for 5x vertical crop in 1080p mode.
Pardon my ignorance, but how do I get these cores to work?
I put them in the folder with my other console cores, set integer scaling to 1 and resolution to 1080p. But when I load a game it's the same as before
I put them in the folder with my other console cores, set integer scaling to 1 and resolution to 1080p. But when I load a game it's the same as before
-
- Posts: 192
- Joined: Sun May 24, 2020 7:59 pm
- Has thanked: 10 times
- Been thanked: 24 times
- SegaSnatcher
- Posts: 163
- Joined: Sun May 24, 2020 9:18 pm
- Has thanked: 36 times
- Been thanked: 43 times
Re: A case for 5x vertical crop in 1080p mode.
And in the case of the NES 5x crop build you'll want to enable both hide overscan and crop toggles.
Also, recommend you choose a filter that only interpolates the horizontal since 5x crop will be a vertical integer.
Also, recommend you choose a filter that only interpolates the horizontal since 5x crop will be a vertical integer.
-
- Posts: 7
- Joined: Mon Jan 25, 2021 6:01 am
- Has thanked: 2 times
- Been thanked: 2 times
Re: A case for 5x vertical crop in 1080p mode.
Thanks
Thanks for the tipSegaSnatcher wrote: ↑Thu Feb 04, 2021 1:10 pm And in the case of the NES 5x crop build you'll want to enable both hide overscan and crop toggles.
Also, recommend you choose a filter that only interpolates the horizontal since 5x crop will be a vertical integer.
- LamerDeluxe
- Top Contributor
- Posts: 1181
- Joined: Sun May 24, 2020 10:25 pm
- Has thanked: 828 times
- Been thanked: 266 times
Re: A case for 5x vertical crop in 1080p mode.
This just now clicked with me, this should work, I'll try this.Yim wrote: ↑Tue Feb 02, 2021 11:56 am I haven’t tried this, but I think you could get horizontal only integer scaling by setting a ratio of (integer upscale):(vertical resolution set by video mode), because the default scaler behaviour is to fill the screen vertically. For example, if you’re running a 256x240 core on 1080p, you could set 1280:1080 for a five times horizontal integer upscale (and a pixel aspect ratio of 5:4.5).
-
- Posts: 7
- Joined: Tue May 26, 2020 4:47 am
- Has thanked: 1 time
- Been thanked: 1 time
Re: A case for 5x vertical crop in 1080p mode.
Hi everybody! I tried kernels with 5x scaling - great at 1080p! Make sure to drag it to the main branch! I'm having some problems with the NES core - it doesn't scale correctly in PAL / Dendy mode. Works normally only in NTSC .. Can I fix it somehow?
-
- Top Contributor
- Posts: 995
- Joined: Thu Dec 10, 2020 5:44 pm
- Has thanked: 309 times
- Been thanked: 228 times
Re: A case for 5x vertical crop in 1080p mode.
Not an easy fix because PAL actually has more vertical resolution. Although not impossible to make a core that does the same cropping in PAL and hope that no game takes advantage of the extra PAL resolution.
-
- Posts: 192
- Joined: Sun May 24, 2020 7:59 pm
- Has thanked: 10 times
- Been thanked: 24 times
- SegaSnatcher
- Posts: 163
- Joined: Sun May 24, 2020 9:18 pm
- Has thanked: 36 times
- Been thanked: 43 times
Re: A case for 5x vertical crop in 1080p mode.
Sorg released a test build of 5x cropping for NES core and its working fantastically. Most importantly custom aspect ratios work with his test build!!!
Here is NES running in glorious 5x by 6x integer scale via custom aspect ratio setting (64:45). Thank You Sorg for considering this feature.
Here is NES running in glorious 5x by 6x integer scale via custom aspect ratio setting (64:45). Thank You Sorg for considering this feature.
- aberu
- Core Developer
- Posts: 1157
- Joined: Tue Jun 09, 2020 8:34 pm
- Location: Longmont, CO
- Has thanked: 244 times
- Been thanked: 403 times
- Contact:
Re: A case for 5x vertical crop in 1080p mode.
I just tested it out and I'd like to report a bug, I can't see all of the pixels that I should be able to see!
jk
jk
birdybro~
- SegaSnatcher
- Posts: 163
- Joined: Sun May 24, 2020 9:18 pm
- Has thanked: 36 times
- Been thanked: 43 times
Re: A case for 5x vertical crop in 1080p mode.
When I created this thread, I had one goal, to try and make a convincing case for 5x crop.
Well today 5x crop option has become an official feature on NES, SNES Genesis, SMS, Mega CD, Neo-Geo and TG-16 cores. Not only that but there is a feature called "crop offset" that allows you to move the image up or down a few notches to gain back any critical information a direct centered crop might lose. Thanks to everyone who gave their thoughts on my thread and most importantly thanks to Grabulosaure and Sorgelig for making it happen.
Now time to have some fun.
Well today 5x crop option has become an official feature on NES, SNES Genesis, SMS, Mega CD, Neo-Geo and TG-16 cores. Not only that but there is a feature called "crop offset" that allows you to move the image up or down a few notches to gain back any critical information a direct centered crop might lose. Thanks to everyone who gave their thoughts on my thread and most importantly thanks to Grabulosaure and Sorgelig for making it happen.
Now time to have some fun.
Re: A case for 5x vertical crop in 1080p mode.
Option is enabled when all these conditions are met:
- Resolution needs to be 1920x1080
- vscale_border isn't used (or vscale_border=0)
- vscale_mode isn't used (or vscale_mode=0)
- forced_scandoubler=0
- in OSD menu Scandoubler Fx:None
-
- Top Contributor
- Posts: 552
- Joined: Sun May 24, 2020 8:07 pm
- Has thanked: 183 times
- Been thanked: 308 times
- Contact:
Re: A case for 5x vertical crop in 1080p mode.
You probably are using something other than vscale_mode=0
- LamerDeluxe
- Top Contributor
- Posts: 1181
- Joined: Sun May 24, 2020 10:25 pm
- Has thanked: 828 times
- Been thanked: 266 times
Re: A case for 5x vertical crop in 1080p mode.
I've just tried it with the Megadrive core and it looks fantastic. Only a bit of the overscan area is cropped, the resulting full-screen image has perfectly clear scanlines, really nice.
Re: A case for 5x vertical crop in 1080p mode.
The new 5x crop option is excellent. Thanks to all who advocated for it, and a special thanks to those who implemented it. Can someone please specify the custom aspect ratios that are needed to get full integer scaling with a 6:5 pixel aspect ratio on NES, Genesis, and SNES? I see 64:45 posted above - is that value correct (I've seen 64:49 posted other places), and does it apply to SNES and Genesis also? Thanks.
Re: A case for 5x vertical crop in 1080p mode.
Bob at retrorgb gave his take on this, and brought up the idea of shifting the image up or down.
https://www.retrorgb.com/mister-1080p-5 ... sting.html
https://www.retrorgb.com/mister-1080p-5 ... sting.html
- SegaSnatcher
- Posts: 163
- Joined: Sun May 24, 2020 9:18 pm
- Has thanked: 36 times
- Been thanked: 43 times
Re: A case for 5x vertical crop in 1080p mode.
64:45 for 6:5.BP_Rod wrote: ↑Thu Feb 11, 2021 2:22 pm The new 5x crop option is excellent. Thanks to all who advocated for it, and a special thanks to those who implemented it. Can someone please specify the custom aspect ratios that are needed to get full integer scaling with a 6:5 pixel aspect ratio on NES, Genesis, and SNES? I see 64:45 posted above - is that value correct (I've seen 64:49 posted other places), and does it apply to SNES and Genesis also? Thanks.
This was implemented. The setting is "Crop Offset".ash2fpga wrote: ↑Thu Feb 11, 2021 4:00 pm Bob at retrorgb gave his take on this, and brought up the idea of shifting the image up or down.
https://www.retrorgb.com/mister-1080p-5 ... sting.html
Re: A case for 5x vertical crop in 1080p mode.
Awesome!SegaSnatcher wrote: ↑Thu Feb 11, 2021 10:23 pmThis was implemented. The setting is "Crop Offset".ash2fpga wrote: ↑Thu Feb 11, 2021 4:00 pm Bob at retrorgb gave his take on this, and brought up the idea of shifting the image up or down.
https://www.retrorgb.com/mister-1080p-5 ... sting.html
Re: A case for 5x vertical crop in 1080p mode.
I recently posted a build of the Genesis core with a menu option for automatic integer horizontal scaling. See this post. I made it with the current Genesis code from GitHub, so although I haven’t tested it it should work with the 5x crop mode. I’d be interested to hear feedback on if it’s working for people.BP_Rod wrote: ↑Thu Feb 11, 2021 2:22 pm Can someone please specify the custom aspect ratios that are needed to get full integer scaling with a 6:5 pixel aspect ratio on NES, Genesis, and SNES? I see 64:45 posted above - is that value correct (I've seen 64:49 posted other places), and does it apply to SNES and Genesis also? Thanks.
I’m kind of confused to see that SMS has a 5x crop option. Again I haven’t tested the latest version, but the SMS’s vertical resolution is 192 so it already fits five times multiplied at 1080p. Is it just for border mode?
- bootsector
- Posts: 162
- Joined: Sun May 24, 2020 6:58 pm
- Has thanked: 4 times
- Been thanked: 30 times
Re: A case for 5x vertical crop in 1080p mode.
Just tried this with 5x vertical crop on and both AR settings in "Original": this is AMAZING! I've got no shimmering on both Narrow and Wide options you gave. No more pursuing the right custom AR settings manually, I believe! I really think Sorgelig should consider adding this to the package, as this will come in super handy for games changing horizontal resolution! Great job!Yim wrote: ↑Fri Feb 12, 2021 4:40 amI recently posted a build of the Genesis core with a menu option for automatic integer horizontal scaling. See this post. I made it with the current Genesis code from GitHub, so although I haven’t tested it it should work with the 5x crop mode. I’d be interested to hear feedback on if it’s working for people.BP_Rod wrote: ↑Thu Feb 11, 2021 2:22 pm Can someone please specify the custom aspect ratios that are needed to get full integer scaling with a 6:5 pixel aspect ratio on NES, Genesis, and SNES? I see 64:45 posted above - is that value correct (I've seen 64:49 posted other places), and does it apply to SNES and Genesis also? Thanks.
I’m kind of confused to see that SMS has a 5x crop option. Again I haven’t tested the latest version, but the SMS’s vertical resolution is 192 so it already fits five times multiplied at 1080p. Is it just for border mode?
-
- Posts: 9
- Joined: Thu Nov 19, 2020 1:04 am
- Has thanked: 21 times
- Been thanked: 2 times
Re: A case for 5x vertical crop in 1080p mode.
I just updated and tested the 5x crop in NES, Genesis, and SNES so far, and it look great, and scrolls much smoother. It also makes things easier to see on the sofa furthest from the TV (about 18' away.) I also saw that there is an offset option which I'm sure will come in handy for some edge case games, but what isn't clear is if the offset setting is per-game or applies core-wide ? The former would seem to make the most sense since most games don't seem to need any offset adjustment from what I've seen thus far, and those that do might need it in different amounts and/or direction.