PWM on 18-bit DAC to get 24-bit Color

Discussion of developmental aspects of the MiSTer Project.
Neocaron
Top Contributor
Posts: 369
Joined: Sun Sep 27, 2020 10:16 am
Has thanked: 202 times
Been thanked: 84 times

Re: PWM on 18-bit DAC to get 24-bit Color

Unread post by Neocaron »

This not being in main still blows my mind XD

Remastering Classic Game Cinematics: My new Youtube fun, check it out :D
https://www.youtube.com/@neocaron87

User avatar
dickhardpill
Posts: 255
Joined: Tue Apr 09, 2024 9:28 pm
Location: Not Portland, OR
Has thanked: 66 times
Been thanked: 50 times
Contact:

Re: PWM on 18-bit DAC to get 24-bit Color

Unread post by dickhardpill »

Ruleset wrote: Sat May 04, 2024 5:45 pm
naylord wrote: Sat May 04, 2024 8:08 am

Would you be able to do a final update on the Saturn core when the core gets buttoned up? Feels like were in the homestretch of development and it would be amazing to have PWM on the final or near final release so it could be the definitive way of playing Saturn games.
Thanks so much again!

I'll make new builds probably about once a month if there are updates. Cores are updated to latest source today.

You are awesome! Thank you it looks pretty darn amazing!

I has a you tube
Analog IO
USB board
VGA > Component
HDMI > FPM

naylord
Posts: 52
Joined: Sat May 21, 2022 11:55 pm
Has thanked: 20 times
Been thanked: 7 times

Re: PWM on 18-bit DAC to get 24-bit Color

Unread post by naylord »

One question, the PWM feature does work with forced_scandoubler right? That's not like a VGA scaler since it just line doubles without needing to do any extra scaling of any kind. To my eye it looks like banding is improved on the Saturn core with scandoubler on with pwm core vs vanilla but I thought I'd double check it's not a placebo if scandoubler disables it like VGA_Scaler does.

Ruleset
Posts: 24
Joined: Fri Dec 01, 2023 1:45 pm
Been thanked: 99 times

Re: PWM on 18-bit DAC to get 24-bit Color

Unread post by Ruleset »

naylord wrote: Thu May 09, 2024 7:44 am

One question, the PWM feature does work with forced_scandoubler right? That's not like a VGA scaler since it just line doubles without needing to do any extra scaling of any kind. To my eye it looks like banding is improved on the Saturn core with scandoubler on with pwm core vs vanilla but I thought I'd double check it's not a placebo if scandoubler disables it like VGA_Scaler does.

Yes, the scandoubler doesn't use the scaler as far a I know, so PWM should work. What games are you testing on Saturn that show a difference? I only could find the FMV in the japanese version of Castlevania that showed less banding, but I didn't try too many games.

metalfacemark
Posts: 179
Joined: Mon Jan 04, 2021 12:04 pm
Has thanked: 22 times
Been thanked: 15 times

Re: PWM on 18-bit DAC to get 24-bit Color

Unread post by metalfacemark »

Thanks, just had a play with this - looks great!

naylord
Posts: 52
Joined: Sat May 21, 2022 11:55 pm
Has thanked: 20 times
Been thanked: 7 times

Re: PWM on 18-bit DAC to get 24-bit Color

Unread post by naylord »

Ruleset wrote: Thu May 09, 2024 1:47 pm
naylord wrote: Thu May 09, 2024 7:44 am

One question, the PWM feature does work with forced_scandoubler right? That's not like a VGA scaler since it just line doubles without needing to do any extra scaling of any kind. To my eye it looks like banding is improved on the Saturn core with scandoubler on with pwm core vs vanilla but I thought I'd double check it's not a placebo if scandoubler disables it like VGA_Scaler does.

Yes, the scandoubler doesn't use the scaler as far a I know, so PWM should work. What games are you testing on Saturn that show a difference? I only could find the FMV in the japanese version of Castlevania that showed less banding, but I didn't try too many games.

I was playing Panzer Dragoon Zwei and it looked like banding was reduced in the FMV. I'll try booting up castlevania as the grey fog in the opening cutscene is a very obvious place to see tons of banding.

User avatar
Dr Johnny Bananas
Posts: 27
Joined: Mon Oct 16, 2023 4:20 am
Has thanked: 4 times
Been thanked: 1 time

Re: PWM on 18-bit DAC to get 24-bit Color

Unread post by Dr Johnny Bananas »

This is very interesting, Saturn is my favorite core. I'm going to try these tonight.

Thank you!

stanenc
Posts: 1
Joined: Wed May 29, 2024 1:47 pm
Been thanked: 1 time

Re: PWM on 18-bit DAC to get 24-bit Color

Unread post by stanenc »

Made an account to say that version 20240408 solved my entire issue I was having on a vga lcd display. Let me know if there is anything I can do to get this into the main branches because this is unbelievable. No way in heck the solution should be to purchase an entirely new board when solutions like this exist.

User avatar
Sarge
Posts: 45
Joined: Tue Jan 12, 2021 5:26 am
Has thanked: 3 times
Been thanked: 5 times

Re: PWM on 18-bit DAC to get 24-bit Color

Unread post by Sarge »

Very impressed with this. Hopefully Sorgelig will relent some day and add to main.

Image
Neocaron
Top Contributor
Posts: 369
Joined: Sun Sep 27, 2020 10:16 am
Has thanked: 202 times
Been thanked: 84 times

Re: PWM on 18-bit DAC to get 24-bit Color

Unread post by Neocaron »

Hello there! If possible could we get this for the N64 turbo core as wel as the PSX turbo core? I have quartus installed and a pretty fast CPU so if it's a modification not too complex, I'd love to do it myself and share it here :D

Remastering Classic Game Cinematics: My new Youtube fun, check it out :D
https://www.youtube.com/@neocaron87

Ruleset
Posts: 24
Joined: Fri Dec 01, 2023 1:45 pm
Been thanked: 99 times

Re: PWM on 18-bit DAC to get 24-bit Color

Unread post by Ruleset »

Neocaron wrote: Thu Jun 20, 2024 8:56 pm

Hello there! If possible could we get this for the N64 turbo core as wel as the PSX turbo core? I have quartus installed and a pretty fast CPU so if it's a modification not too complex, I'd love to do it myself and share it here :D

Sure you can try if you want. You will have to get the source from FPGAZumSpass and ask what the minimum acceptable timing slacks are.

Just add everything that is in this commit: https://github.com/Jokippo/N64_MiSTer_P ... baca5ce720

FPGAZumSpass did mention it took him 10 hours on a 13900k with 8 builds in parallel to get a good N64 Turbo build, and that was without PWM added, so I don't know if it is even possible. But I can add the build to the OP if you succeed.

KennyL
Posts: 116
Joined: Sun May 24, 2020 11:40 pm
Has thanked: 72 times
Been thanked: 38 times

Re: PWM on 18-bit DAC to get 24-bit Color

Unread post by KennyL »

Thank you so much for keeping these cores updated and fixing n64 core!

KennyL
Posts: 116
Joined: Sun May 24, 2020 11:40 pm
Has thanked: 72 times
Been thanked: 38 times

Re: PWM on 18-bit DAC to get 24-bit Color

Unread post by KennyL »

Thank you again for the update!

PSX_PWM_20240831.rbf update contains big MDEC update by paulb-nl et al. that fixes many 2d background and fmv issues.

https://github.com/MiSTer-devel/PSX_MiSTer/issues/260

Looking at this comparison provided by Robert, MDEC accuracy is getting super close!

grafik.png
grafik.png (2.31 MiB) Viewed 2373 times
naylord
Posts: 52
Joined: Sat May 21, 2022 11:55 pm
Has thanked: 20 times
Been thanked: 7 times

Re: PWM on 18-bit DAC to get 24-bit Color

Unread post by naylord »

Just playing some Gurentai on the pwm saturn core. It's incredible how great it looks on my 31khz vga monitor! Only issue is with the scandoubler the start menu is always in 480i (which makes sense, lots of text, static movement so no interlacing artifacts really) but because of that the scandoubler doesn't seem to work so I have to do those menus blind but I'm just getting such a pristine banding free image for gameplay it just can't be beat.

amano
Posts: 3
Joined: Fri Sep 06, 2024 7:57 pm
Has thanked: 2 times

Re: PWM on 18-bit DAC to get 24-bit Color

Unread post by amano »

Can this patch be included in the N64 Turbo Core?

Ruleset
Posts: 24
Joined: Fri Dec 01, 2023 1:45 pm
Been thanked: 99 times

Re: PWM on 18-bit DAC to get 24-bit Color

Unread post by Ruleset »

amano wrote: Tue Sep 17, 2024 4:29 pm

Can this patch be included in the N64 Turbo Core?

I will probably try to make a turbo PWM build once FPGAZumSpass updates the turbo core, but I can't guarantee that a build is possible.

Xtro
Posts: 8
Joined: Sun Aug 02, 2020 10:15 am
Has thanked: 1 time
Been thanked: 1 time

Re: PWM on 18-bit DAC to get 24-bit Color

Unread post by Xtro »

It would be nice adding support to Minimig core, at least AGA Amigas would benefit from a PWM build

Mysteryberto
Posts: 2
Joined: Mon Dec 06, 2021 7:03 pm
Been thanked: 1 time

Re: PWM on 18-bit DAC to get 24-bit Color

Unread post by Mysteryberto »

Thanks so much for these cores. I was playing Mario 64 the other day and noticed the banding in the main hall. After loading the PWM core it was all gone!

Marlus
Posts: 4
Joined: Sat Oct 21, 2023 12:50 am

Re: PWM on 18-bit DAC to get 24-bit Color

Unread post by Marlus »

Hello friends, I started using the PS1's CORE PWM today and unfortunately the problem with the color remains. Am I doing something wrong?

Game: Dino Crisis 2

Image

Image

Ruleset
Posts: 24
Joined: Fri Dec 01, 2023 1:45 pm
Been thanked: 99 times

Re: PWM on 18-bit DAC to get 24-bit Color

Unread post by Ruleset »

Marlus wrote: Sat Oct 05, 2024 4:01 pm

Hello friends, I started using the PS1's CORE PWM today and unfortunately the problem with the color remains. Am I doing something wrong?

Game: Dino Crisis 2

Do you mean that the picture has too much red in the PWM build? Is this also the case in the regular build?

Marlus
Posts: 4
Joined: Sat Oct 21, 2023 12:50 am

Re: PWM on 18-bit DAC to get 24-bit Color

Unread post by Marlus »

Between CORE PSX_PWM and Original Hardware there appears to be a color difference. in Dino Crisis 2 you can clearly notice the difference, I also noticed it in RE3. Green sometimes appears grayish or non-existent. When compared to HDMI, the difference is also very noticeable.

Image

Image

Image

Image

Post Reply