FM Sound option gone

User avatar
Threepwood
Posts: 133
Joined: Mon May 25, 2020 9:14 am
Has thanked: 4 times
Been thanked: 23 times

FM Sound option gone

Unread post by Threepwood »

Since the latest framework update the FM-Sound option is gone? I can't find it anymore.
12characters
Posts: 112
Joined: Wed Jun 03, 2020 5:39 pm
Has thanked: 8 times
Been thanked: 30 times

Re: FM Sound option gone

Unread post by 12characters »

Threepwood wrote: Sat Jun 06, 2020 7:51 pm Since the latest framework update the FM-Sound option is gone? I can't find it anymore.
I cannot find it either. If one has set the option before, it seems to still apply though.
User avatar
Sorgelig
Site Admin
Posts: 877
Joined: Thu May 21, 2020 9:49 pm
Has thanked: 2 times
Been thanked: 211 times

Re: FM Sound option gone

Unread post by Sorgelig »

Let's spam everywhere!
User avatar
Threepwood
Posts: 133
Joined: Mon May 25, 2020 9:14 am
Has thanked: 4 times
Been thanked: 23 times

Re: FM Sound option gone

Unread post by Threepwood »

12characters wrote: Sun Jun 07, 2020 1:47 pm I cannot find it either. If one has set the option before, it seems to still apply though.
I reported it on github and it is fixed already: https://github.com/MiSTer-devel/SMS_MiSTer/issues/71

https://github.com/MiSTer-devel/SMS_MiSTer/pull/72

Will surely be part of the next SMS release.

EDIT:
Sorgelig wrote: Sun Jun 07, 2020 2:11 pm Let's spam everywhere!
After I posted here I remembered github and thought that it is probably better to report it as an issue there. Sorry for the inconvenience, Sorg.
rhester72
Top Contributor
Posts: 1107
Joined: Thu Jun 11, 2020 2:31 am
Has thanked: 13 times
Been thanked: 169 times

Re: FM Sound option gone

Unread post by rhester72 »

Was this ever actually fixed? I saw where a fix put in, but I can't get it to appear with any ROM for any region.
12characters
Posts: 112
Joined: Wed Jun 03, 2020 5:39 pm
Has thanked: 8 times
Been thanked: 30 times

Re: FM Sound option gone

Unread post by 12characters »

rhester72 wrote: Thu Jul 02, 2020 1:21 pm Was this ever actually fixed? I saw where a fix put in, but I can't get it to appear with any ROM for any region.
There has not been any release after the fix.
rhester72
Top Contributor
Posts: 1107
Joined: Thu Jun 11, 2020 2:31 am
Has thanked: 13 times
Been thanked: 169 times

Re: FM Sound option gone

Unread post by rhester72 »

Thank you - this was the push I needed to get the Quartus environment up and running.

Compiled and confirmed the fix works - thanks again!
User avatar
Threepwood
Posts: 133
Joined: Mon May 25, 2020 9:14 am
Has thanked: 4 times
Been thanked: 23 times

Re: FM Sound option gone

Unread post by Threepwood »

rhester72 wrote: Fri Jul 03, 2020 1:19 am Compiled and confirmed the fix works
Would you be willing to share the compiled core here?
rhester72
Top Contributor
Posts: 1107
Joined: Thu Jun 11, 2020 2:31 am
Has thanked: 13 times
Been thanked: 169 times

Re: FM Sound option gone

Unread post by rhester72 »

So far, the question (to the project lead) of being allowed to share custom-compiled cores has been raised but not answered...I'd rather not do so without his blessing, especially since the software required to compile your own is readily available and free.
User avatar
Threepwood
Posts: 133
Joined: Mon May 25, 2020 9:14 am
Has thanked: 4 times
Been thanked: 23 times

Re: FM Sound option gone

Unread post by Threepwood »

I doubt that it is an issue to attach a core compiled from unmodified sources. Besides that it is a forum attachment and nothing that will be pushed to people via updater script.

In case others want to use the core I compiled:
SMS_20200714.zip
(1.09 MiB) Downloaded 295 times
User avatar
Moondandy
Top Contributor
Posts: 535
Joined: Mon May 25, 2020 2:14 am
Location: Edinburgh, Scotland
Has thanked: 32 times
Been thanked: 97 times

Re: FM Sound option gone

Unread post by Moondandy »

So is FM sound still not added back into the core?
User avatar
Threepwood
Posts: 133
Joined: Mon May 25, 2020 9:14 am
Has thanked: 4 times
Been thanked: 23 times

Re: FM Sound option gone

Unread post by Threepwood »

Moondandy wrote: Tue Jul 14, 2020 3:00 am So is FM sound still not added back into the core?
It has been fixed in the sources five weeks ago, there just never was a fixed release.

In the compiled core that I attached "SMS FM Sound" is in "Audio & Video".
User avatar
Moondandy
Top Contributor
Posts: 535
Joined: Mon May 25, 2020 2:14 am
Location: Edinburgh, Scotland
Has thanked: 32 times
Been thanked: 97 times

Re: FM Sound option gone

Unread post by Moondandy »

Huh, so how come nobody has released the fixed version? Seems odd the fix hasn't made it back to Main.
User avatar
wark91
Core Developer
Posts: 334
Joined: Sun May 24, 2020 8:34 pm
Has thanked: 447 times
Been thanked: 94 times

Re: FM Sound option gone

Unread post by wark91 »

Maybe other fixes since the last release required more tests
rhester72
Top Contributor
Posts: 1107
Joined: Thu Jun 11, 2020 2:31 am
Has thanked: 13 times
Been thanked: 169 times

Re: FM Sound option gone

Unread post by rhester72 »

Not in this case - it was an obvious one-line fix with no check-ins since. This one confuses me too.
User avatar
Moondandy
Top Contributor
Posts: 535
Joined: Mon May 25, 2020 2:14 am
Location: Edinburgh, Scotland
Has thanked: 32 times
Been thanked: 97 times

Re: FM Sound option gone

Unread post by Moondandy »

Is it possible Sorg has forgotten to release this? It has been sitting marked as fixed for a long time now...

As an aside, the MDFourier gang have acquired a Japanese MS and FM module so that hopefully will pave the way for more accurate FM sound on the core.
User avatar
eightbit
Posts: 53
Joined: Thu Jun 18, 2020 7:05 pm
Has thanked: 1 time
Been thanked: 3 times

Re: FM Sound option gone

Unread post by eightbit »

Threepwood wrote: Mon Jul 13, 2020 10:50 pm I doubt that it is an issue to attach a core compiled from unmodified sources. Besides that it is a forum attachment and nothing that will be pushed to people via updater script.

In case others want to use the core I compiled: SMS_20200714.zip
Thanks a lot for this. In my case the FM sound was by default enabled...with no option to turn it off. In the USA we never had the FM sound so it just sounds weird and unnatural to us here :)
User avatar
Moondandy
Top Contributor
Posts: 535
Joined: Mon May 25, 2020 2:14 am
Location: Edinburgh, Scotland
Has thanked: 32 times
Been thanked: 97 times

Re: FM Sound option gone

Unread post by Moondandy »

Has this fix still not come through to Main yet?
rhester72
Top Contributor
Posts: 1107
Joined: Thu Jun 11, 2020 2:31 am
Has thanked: 13 times
Been thanked: 169 times

Re: FM Sound option gone

Unread post by rhester72 »

Still not, oddly enough.
User avatar
Moondandy
Top Contributor
Posts: 535
Joined: Mon May 25, 2020 2:14 am
Location: Edinburgh, Scotland
Has thanked: 32 times
Been thanked: 97 times

Re: FM Sound option gone

Unread post by Moondandy »

Re: MiSTer updates and changelog
Unread post by Sorgelig » Wed Aug 19, 2020 4:02 pm

SMS:
- Fix FM OSD option.
- Update the framework.

Thanks Sorg!
Post Reply