Page 1 of 1

Penguin-Kun Wars moving from unofficial to main?

Posted: Wed Sep 21, 2022 4:05 pm
by KremlingKuthroat19
Penguin-Kun Wars was a core being developed by the great developer MiSTer-X. Sadly, health issues have debilitated him and he's since retired from MiSTer development. His Github page for the unofficial core is here: https://github.com/MrX-8B/MiSTer-Arcade-PenguinKunWars

Would anyone be interested in picking up this core and polishing it up for an official release in main?

Re: Penguin-Kun Wars moving from unofficial to main?

Posted: Tue Sep 27, 2022 10:47 pm
by macro
I'll update the SYS to the latest, make sure it builds OK and check it in.

Re: Penguin-Kun Wars moving from unofficial to main?

Posted: Thu Sep 29, 2022 9:17 pm
by macro
Have updated and removed a few warnings, but need to do some testing before adding it to the repository.

Re: Penguin-Kun Wars moving from unofficial to main?

Posted: Fri Sep 30, 2022 10:55 pm
by KremlingKuthroat19
macro wrote: Thu Sep 29, 2022 9:17 pm Have updated and removed a few warnings, but need to do some testing before adding it to the repository.
Thank you for looking into this!

Re: Penguin-Kun Wars moving from unofficial to main?

Posted: Sun Oct 02, 2022 9:48 pm
by macro
All works for me using keyboard or joystick, so now checked in.

What an odd game, I lost about 5 times in a row, although lasted much longer towards the end!

Re: Penguin-Kun Wars moving from unofficial to main?

Posted: Mon Oct 03, 2022 12:27 am
by MikeS1
Oh Nice! I was working on getting this, Nova 2001 and Raiders5 ported over from Mist. I didnt know he had finished this core, I'm assuming they all work on MiST though..

Re: Penguin-Kun Wars moving from unofficial to main?

Posted: Mon Oct 03, 2022 4:20 am
by aberu
Thanks for bringing this in!

Re: Penguin-Kun Wars moving from unofficial to main?

Posted: Mon Oct 03, 2022 3:40 pm
by KremlingKuthroat19
Thank you for your hard work! For some reason, it's not getting picked up by update_all though. Does anyone know why the scripts aren't picking it up?

Re: Penguin-Kun Wars moving from unofficial to main?

Posted: Mon Oct 03, 2022 4:05 pm
by jca
Same here. I have the old rbf and mras downloaded last April. I am not sure were they came from. The update all script did not download anything new for this core.

Re: Penguin-Kun Wars moving from unofficial to main?

Posted: Mon Oct 03, 2022 4:12 pm
by jca
Last time I ran the script was yesterday. I just ran it again to see if it would download the core and it did:
No changes: _Arcade/Penguin-Kun_Wars.mra
No changes: _Arcade/Penguin-Kun_Wars_Japan.mra
Downloading 1 files:
_Arcade/cores/PenguinKunWars_20221002.rbf
Must be some gremlin.

Re: Penguin-Kun Wars moving from unofficial to main?

Posted: Mon Oct 03, 2022 6:24 pm
by fierman
jca wrote: Mon Oct 03, 2022 4:12 pm Last time I ran the script was yesterday. I just ran it again to see if it would download the core and it did:
No changes: _Arcade/Penguin-Kun_Wars.mra
No changes: _Arcade/Penguin-Kun_Wars_Japan.mra
Downloading 1 files:
_Arcade/cores/PenguinKunWars_20221002.rbf
Must be some gremlin.
Before claiming there are issues, please learn how the MiSTer distribution system works, and how the updater scripts work with github and the various repositories. You would have found out in a few seconds that the mra files themselves have not been touched for over 2 years - and that there is no need for them to change either. In other words: everything works as expected.

Re: Penguin-Kun Wars moving from unofficial to main?

Posted: Mon Oct 03, 2022 6:32 pm
by KremlingKuthroat19
It works now with update all. Have fun :)

Re: Penguin-Kun Wars moving from unofficial to main?

Posted: Mon Oct 03, 2022 6:41 pm
by jca
fierman wrote: Mon Oct 03, 2022 6:24 pm Before claiming there are issues, please learn how the MiSTer distribution system works, and how the updater scripts work with github and the various repositories. You would have found out in a few seconds that the mra files themselves have not been touched for over 2 years - and that there is no need for them to change either. In other words: everything works as expected.
Before making your post please read what I wrote. I just said that now the rbf was downloaded. I just posted the result of the update all screen and did not say a word about the mras. I am not stupid: if the script did not download the mras I know it is because they did not change.
People have this bad habit of criticizing others for no reason.