Penguin-Kun Wars moving from unofficial to main?

KremlingKuthroat19
Posts: 237
Joined: Sat Aug 22, 2020 3:08 am
Has thanked: 27 times
Been thanked: 49 times

Penguin-Kun Wars moving from unofficial to main?

Unread post by KremlingKuthroat19 »

Penguin-Kun Wars was a core being developed by the great developer MiSTer-X. Sadly, health issues have debilitated him and he's since retired from MiSTer development. His Github page for the unofficial core is here: https://github.com/MrX-8B/MiSTer-Arcade-PenguinKunWars

Would anyone be interested in picking up this core and polishing it up for an official release in main?
User avatar
macro
Core Developer
Posts: 138
Joined: Sun May 24, 2020 4:12 pm
Been thanked: 171 times

Re: Penguin-Kun Wars moving from unofficial to main?

Unread post by macro »

I'll update the SYS to the latest, make sure it builds OK and check it in.
Did I do something useful?

buy me a coffee
User avatar
macro
Core Developer
Posts: 138
Joined: Sun May 24, 2020 4:12 pm
Been thanked: 171 times

Re: Penguin-Kun Wars moving from unofficial to main?

Unread post by macro »

Have updated and removed a few warnings, but need to do some testing before adding it to the repository.
Did I do something useful?

buy me a coffee
KremlingKuthroat19
Posts: 237
Joined: Sat Aug 22, 2020 3:08 am
Has thanked: 27 times
Been thanked: 49 times

Re: Penguin-Kun Wars moving from unofficial to main?

Unread post by KremlingKuthroat19 »

macro wrote: Thu Sep 29, 2022 9:17 pm Have updated and removed a few warnings, but need to do some testing before adding it to the repository.
Thank you for looking into this!
User avatar
macro
Core Developer
Posts: 138
Joined: Sun May 24, 2020 4:12 pm
Been thanked: 171 times

Re: Penguin-Kun Wars moving from unofficial to main?

Unread post by macro »

All works for me using keyboard or joystick, so now checked in.

What an odd game, I lost about 5 times in a row, although lasted much longer towards the end!
Did I do something useful?

buy me a coffee
MikeS1
Core Developer
Posts: 98
Joined: Wed Feb 03, 2021 12:24 am
Has thanked: 29 times
Been thanked: 128 times

Re: Penguin-Kun Wars moving from unofficial to main?

Unread post by MikeS1 »

Oh Nice! I was working on getting this, Nova 2001 and Raiders5 ported over from Mist. I didnt know he had finished this core, I'm assuming they all work on MiST though..
User avatar
aberu
Core Developer
Posts: 1144
Joined: Tue Jun 09, 2020 8:34 pm
Location: Longmont, CO
Has thanked: 244 times
Been thanked: 388 times
Contact:

Re: Penguin-Kun Wars moving from unofficial to main?

Unread post by aberu »

Thanks for bringing this in!
birdybro~
KremlingKuthroat19
Posts: 237
Joined: Sat Aug 22, 2020 3:08 am
Has thanked: 27 times
Been thanked: 49 times

Re: Penguin-Kun Wars moving from unofficial to main?

Unread post by KremlingKuthroat19 »

Thank you for your hard work! For some reason, it's not getting picked up by update_all though. Does anyone know why the scripts aren't picking it up?
jca
Top Contributor
Posts: 1911
Joined: Wed May 27, 2020 1:59 pm
Has thanked: 145 times
Been thanked: 454 times

Re: Penguin-Kun Wars moving from unofficial to main?

Unread post by jca »

Same here. I have the old rbf and mras downloaded last April. I am not sure were they came from. The update all script did not download anything new for this core.
jca
Top Contributor
Posts: 1911
Joined: Wed May 27, 2020 1:59 pm
Has thanked: 145 times
Been thanked: 454 times

Re: Penguin-Kun Wars moving from unofficial to main?

Unread post by jca »

Last time I ran the script was yesterday. I just ran it again to see if it would download the core and it did:
No changes: _Arcade/Penguin-Kun_Wars.mra
No changes: _Arcade/Penguin-Kun_Wars_Japan.mra
Downloading 1 files:
_Arcade/cores/PenguinKunWars_20221002.rbf
Must be some gremlin.
fierman
Posts: 111
Joined: Mon Mar 28, 2022 11:08 pm
Has thanked: 83 times
Been thanked: 23 times

Re: Penguin-Kun Wars moving from unofficial to main?

Unread post by fierman »

jca wrote: Mon Oct 03, 2022 4:12 pm Last time I ran the script was yesterday. I just ran it again to see if it would download the core and it did:
No changes: _Arcade/Penguin-Kun_Wars.mra
No changes: _Arcade/Penguin-Kun_Wars_Japan.mra
Downloading 1 files:
_Arcade/cores/PenguinKunWars_20221002.rbf
Must be some gremlin.
Before claiming there are issues, please learn how the MiSTer distribution system works, and how the updater scripts work with github and the various repositories. You would have found out in a few seconds that the mra files themselves have not been touched for over 2 years - and that there is no need for them to change either. In other words: everything works as expected.
KremlingKuthroat19
Posts: 237
Joined: Sat Aug 22, 2020 3:08 am
Has thanked: 27 times
Been thanked: 49 times

Re: Penguin-Kun Wars moving from unofficial to main?

Unread post by KremlingKuthroat19 »

It works now with update all. Have fun :)
jca
Top Contributor
Posts: 1911
Joined: Wed May 27, 2020 1:59 pm
Has thanked: 145 times
Been thanked: 454 times

Re: Penguin-Kun Wars moving from unofficial to main?

Unread post by jca »

fierman wrote: Mon Oct 03, 2022 6:24 pm Before claiming there are issues, please learn how the MiSTer distribution system works, and how the updater scripts work with github and the various repositories. You would have found out in a few seconds that the mra files themselves have not been touched for over 2 years - and that there is no need for them to change either. In other words: everything works as expected.
Before making your post please read what I wrote. I just said that now the rbf was downloaded. I just posted the result of the update all screen and did not say a word about the mras. I am not stupid: if the script did not download the mras I know it is because they did not change.
People have this bad habit of criticizing others for no reason.
Post Reply